Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azcore.ResponseError fails to marshal #23454

Closed
KStillings-Slalom opened this issue Sep 18, 2024 · 3 comments · Fixed by #23532
Closed

azcore.ResponseError fails to marshal #23454

KStillings-Slalom opened this issue Sep 18, 2024 · 3 comments · Fixed by #23532
Assignees
@jhendrixMSFT
Labels
Azure.Core customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team

Comments

@KStillings-Slalom
Copy link

Bug Report

When trying to marshal the azcore.ResponseError into a data object, an unsupportedType occurs.
If we null out the azcore.ResponseError.RawResponse.Request object, the error marshals out as expected.

It appears this might be related to 21838 and 22147

It would be nice to be able to marshal this out as well so we can return a full error context back to the client.
@github-actions github-actions bot added Azure.Core customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Sep 18, 2024
@github-actions GitHub Actions
Copy link

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@jhendrixMSFT jhendrixMSFT removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Mgmt This issue is related to a management-plane library. labels Sep 18, 2024
@jhendrixMSFT
Copy link
Member

The safest thing for us to do is omit the RawResponse field from marshaling. It's lossy though, so calling Error() on the unmarshaled instance won't contain full info. This shouldn't be a problem as that output is not contractual (only ErrorCode and StatusCode are), but I'd like to know a bit more about your scenario.

@jhendrixMSFT jhendrixMSFT mentioned this issue Oct 1, 2024
Merged
@jhendrixMSFT
Copy link
Member

Fix will be in upcoming v1.14.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhendrixMSFT jhendrixMSFT

Labels
Azure.Core customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Omit RawResponse from JSON payload jhendrixMSFT/azure-sdk-for-go
2 participants
@jhendrixMSFT @KStillings-Slalom