Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fakes poller accepted HTTP Status Codes #23473

Closed
gracewilcox opened this issue Sep 19, 2024 · 1 comment · Fixed by Azure/autorest.go#1436
Closed

Fakes poller accepted HTTP Status Codes #23473

gracewilcox opened this issue Sep 19, 2024 · 1 comment · Fixed by Azure/autorest.go#1436
Assignees
@jhendrixMSFT
Labels
Azure.Core CodeGen Issues that relate to code generation

Comments

@gracewilcox
Copy link
Member

The fake poller will throw an error if the HTTP response status code doesn't exactly match what is expected. In reality, our pollers are more flexible with the status codes they accept.

Investigate whether to modify the behavior in the poller for fakes.
@gracewilcox gracewilcox added CodeGen Issues that relate to code generation Azure.Core labels Sep 19, 2024
@jhendrixMSFT jhendrixMSFT mentioned this issue Oct 4, 2024
Merged
@jhendrixMSFT
Copy link
Member

Fixed in upcoming [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhendrixMSFT jhendrixMSFT

Labels
Azure.Core CodeGen Issues that relate to code generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fake pollers accept more status codes jhendrixMSFT/autorest.go
2 participants
@jhendrixMSFT @gracewilcox