Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key Management API for Function App #2397

Closed
TsuyoshiUshio opened this issue Aug 6, 2018 · 14 comments
Closed

Key Management API for Function App #2397

TsuyoshiUshio opened this issue Aug 6, 2018 · 14 comments
Assignees
Labels
App Services feature-request This issue requires a new behavior in the product in order be resolved. Mgmt This issue is related to a management-plane library.

Comments

@TsuyoshiUshio
Copy link

Feature Request

For the deployment of the FunctionApp, we frequently use Key Management API. However, there is no interface on the Azure SDK for go.

For more detail.
https://github.com/Azure/azure-functions-host/wiki/Key-management-API

it is used to fetch Azure Functions function keys, host keys, system keys.

I tried to contribute Terraform to enable this feature. The repo owner said that that feature should
be in this repo. I agree with him.

hashicorp/terraform-provider-azurerm#1493

Of course, If you don't afford it, I'm happy to contribute this. However, since that API is not coming from Swagger definition, I'm not sure where should I implement it.

@joshgav
Copy link
Contributor

joshgav commented Aug 6, 2018

Thanks for reporting this @TsuyoshiUshio, we'll look into how we can support Functions APIs. I noticed this one too: https://github.com/Azure/azure-functions-host/wiki/Admin-API, are there others?

Note to readers that this isn't directly related to support for Go functions themselves, but an ask for a Go package for managing functions. Please follow #894 if you're interested in Go functions.

cc @asavaritayal @vladbarosan @kirthik

@tombuildsstuff
Copy link
Contributor

@joshgav admittedly I haven't had time to check it, but at a first glance the API responses look a lot like Kudu, so I'm wondering if that's what's powering this?

@joshgav
Copy link
Contributor

joshgav commented Aug 6, 2018

@tombuildsstuff indeed it is :). I know we've discussed Kudu APIs before, are you awaiting support for some of them still? Thanks!

@tombuildsstuff
Copy link
Contributor

@joshgav cool thanks for confirming; we are - but it's not something we need immediately, do you have a rough timeline for this? Thanks!

@joshgav joshgav added the backlog label Aug 7, 2018
@TsuyoshiUshio
Copy link
Author

TsuyoshiUshio commented Aug 7, 2018

Thank you @joshgav and @tombuildsstuff

I didn't notice that API too. I'll ask the Azure Function Product team and share with you guys.
No worries, I like go, however, I just DevOps guys, I'm interested in the feature of the Terraform. :)

At least, https://github.com/Azure/azure-functions-host/wiki/Key-management-API is frequently used for automation of the deployment for Azure Functions function/host/system keys, Durable Functions status check and so on. It is also used integration with Event Grid. Since it is not ARM api. ARM api only provide us to give us an access token for the api. Then we need to access it using the access token by our selves.

e.g.

@joshgav
Copy link
Contributor

joshgav commented Aug 8, 2018

cc @jeffhollan from the Functions team to comment on plans for packages supporting Kudu APIs

@tombuildsstuff
Copy link
Contributor

ping @jeffhollan :)

@jeffhollan
Copy link

I wouldn't build this out yet with the current APIs that exist. We have work planned for later this year that will surface the APIs in a much more friendly way. Any work we do in the interim would likely be throwaway.

@vladbarosan
Copy link

@jeffhollan any updates on the new API being available ?

@jeffhollan
Copy link

Just pinging this thread - the updates aren't out yet but they are on the way so this is likely a good time to look at what the new API surface will be in the coming weeks. @mattchenderson is the point of contact on the API side from our side.

@seppi91
Copy link

seppi91 commented Jun 12, 2019

@mattchenderson can you give us some update when the new API will be available?

@mikhailshilkov
Copy link

The new API has been deployed and the upstream issue Azure/azure-functions-host#3994 is closed. I suppose the issue isn't blocked anymore.

@ericsampson
Copy link

@joshgav is this waiting for community implementation?

@tzhanl tzhanl added the Mgmt This issue is related to a management-plane library. label Nov 18, 2020
@RickWinter RickWinter added this to the Backlog milestone Jul 12, 2021
@RickWinter RickWinter added the feature-request This issue requires a new behavior in the product in order be resolved. label Sep 17, 2021
@lirenhe
Copy link
Member

lirenhe commented Sep 28, 2021

The issue was last updated about 2 years ago and as described, such APIs already existed.
As the GO SDK is generated from Swagger, I expected the function is also there. Please let me know if you still have issue.

@lirenhe lirenhe closed this as completed Sep 28, 2021
@RickWinter RickWinter modified the milestones: Backlog, [2021] October Dec 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
App Services feature-request This issue requires a new behavior in the product in order be resolved. Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

No branches or pull requests