Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unneeded set_identifier_uris.sh from azure-spring-samples project #27766

Closed
chenrujun opened this issue Mar 21, 2022 · 1 comment
Closed
Labels
azure-spring All azure-spring related issues azure-spring-samples Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone

Comments

@chenrujun
Copy link

chenrujun commented Mar 21, 2022

Context

https://github.com/Azure-Samples/azure-spring-boot-samples/pull/217/files introduced set_identifier_uris.sh . It's used to set client-id in identifier URI. It can be deleted, not use client-id as a part of identifier URI. Keep this logic may make it harder to startup these samples.

Goal

Make it easier to start those samples by deleting all set_identifier_uris.sh, not use client-id as a part of identifier URI.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 21, 2022
@chenrujun chenrujun self-assigned this Mar 21, 2022
@chenrujun chenrujun added the Client This issue points to a problem in the data-plane of the library. label Mar 21, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 21, 2022
@chenrujun chenrujun added azure-spring All azure-spring related issues Samples azure-spring-samples labels Mar 21, 2022
@chenrujun chenrujun moved this to Todo in Spring Cloud Azure Mar 21, 2022
@chenrujun chenrujun added this to the [2022] May milestone Mar 21, 2022
@chenrujun chenrujun assigned Netyyyy and unassigned chenrujun Mar 21, 2022
@stliu stliu added the feature-request This issue requires a new behavior in the product in order be resolved. label Apr 3, 2022
@chenrujun chenrujun changed the title Delete set_identifier_uris.sh Delete unneeded set_identifier_uris.sh from azure-spring-samples project Apr 3, 2022
@stliu stliu modified the milestones: [2022] May, Backlog Apr 3, 2022
@backwind1233 backwind1233 modified the milestones: Backlog, [2022] May Apr 7, 2022
@saragluna saragluna removed the Samples label Apr 27, 2022
@saragluna saragluna modified the milestones: [2022] May, Backlog May 9, 2022
@Netyyyy Netyyyy removed their assignment Dec 8, 2022
Copy link

Hi @chenrujun, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Spring Cloud Azure Mar 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure-spring All azure-spring related issues azure-spring-samples Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Archived in project
Development

No branches or pull requests

5 participants