Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] EventHubs distributed tracing: span kind changes #6772

Closed
2 tasks done
lmolkova opened this issue Dec 11, 2019 · 0 comments · Fixed by #7913
Closed
2 tasks done

[FEATURE REQ] EventHubs distributed tracing: span kind changes #6772

lmolkova opened this issue Dec 11, 2019 · 0 comments · Fixed by #7913
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs

Comments

@lmolkova
Copy link
Member

Is your feature request related to a problem? Please describe.
Tracing visualization tools need to know when they are dealing with async messaging scenarios.

Describe the solution you'd like

EventHub spans kinds were not correct in the previous guidance. They should be changed to

  • Message: 'producer' kind for OpenTelemtery (was 'internal'). OpenCensus does not support 'producer' - 'internal' should still be used there
  • Send: 'client' kind (was 'producer')
  • Processing: 'consumer' kind (was 'server'), OpenCensus should continue using 'server'

Note: As discussed offline, opencensus support may be dropped at this point.

This complies with OpenTelemetry semantics and helps backend tools understand they are dealing with async message processing and visualize it accordingly.

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Description Added
  • Expected solution specified
@lmolkova lmolkova changed the title [FEATURE REQ] [FEATURE REQ] EventHubs distributed tracing: span kind changes Dec 11, 2019
@joshfree joshfree added Client This issue points to a problem in the data-plane of the library. Event Hubs labels Dec 17, 2019
@joshfree joshfree added this to the [2020] January milestone Dec 17, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants