Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Refactor TextAnalyticsAsyncClient and SyncClient. #6965

Closed
mssfang opened this issue Dec 19, 2019 · 1 comment
Closed

[Feature] Refactor TextAnalyticsAsyncClient and SyncClient. #6965

mssfang opened this issue Dec 19, 2019 · 1 comment
Assignees
@samvaity @mssfang
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics

Comments

@mssfang
Copy link
Member

mssfang commented Dec 19, 2019

"There are almost twenty methods in this class that are used only once (these convert methods or map). It adds additional complexity to this class and makes it hard to maintain.

Functions should be pieces of code that are reused throughout the class."
@mssfang mssfang added Client This issue points to a problem in the data-plane of the library. Text Analytics labels Dec 19, 2019
@mssfang mssfang self-assigned this Dec 19, 2019
@mssfang mssfang mentioned this issue Dec 19, 2019
Merged
@samvaity samvaity mentioned this issue Dec 26, 2019
Merged
@samvaity
Copy link
Member

samvaity commented Jan 3, 2020

Closed in #7050

@samvaity samvaity closed this as completed Jan 3, 2020
@samvaity samvaity self-assigned this Jan 7, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@samvaity samvaity

@mssfang mssfang

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samvaity @mssfang