Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Checkstyle] IllegalArgumentException is thrown but never documented. #7147

Closed
mssfang opened this issue Jan 6, 2020 · 0 comments
Closed

[Checkstyle] IllegalArgumentException is thrown but never documented. #7147

mssfang opened this issue Jan 6, 2020 · 0 comments
Assignees
@mssfang
Labels
Client This issue points to a problem in the data-plane of the library. Java Source Code Rules
Milestone
Backlog

Comments

@mssfang
Copy link
Member

mssfang commented Jan 6, 2020

IllegalArgumentException has been getting thrown for a while but never documented, we have a Checkstyle rule that should fail PR validation due to this.

#7121 (comment)
@mssfang mssfang self-assigned this Jan 6, 2020
@mssfang mssfang mentioned this issue Jan 6, 2020
Merged
@joshfree joshfree added the Client This issue points to a problem in the data-plane of the library. label Jul 16, 2020
@joshfree joshfree changed the title [Checkstyle] IllegalArguementException is thrown but never docunmented. [Checkstyle] IllegalArgumentException is thrown but never documented. Jul 16, 2020
@joshfree joshfree added this to the Backlog milestone Jul 16, 2020
@mssfang mssfang closed this as completed Feb 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mssfang mssfang

Labels
Client This issue points to a problem in the data-plane of the library. Java Source Code Rules
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@joshfree @mssfang