diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml index 426ba7af0af9..ae2117368718 100644 --- a/common/config/rush/pnpm-lock.yaml +++ b/common/config/rush/pnpm-lock.yaml @@ -392,8 +392,8 @@ packages: tslib: 2.3.1 dev: false - /@azure/communication-signaling/1.0.0-beta.10: - resolution: {integrity: sha512-1eQphUq80S+vF79h3SooOLcMuhSreB3CYwlVQWV31AX1ypfc6QvaIsAumIPMw48R9CSyZJ67wub0hKHR8WsFSg==} + /@azure/communication-signaling/1.0.0-beta.11: + resolution: {integrity: sha512-+erzTnfEB0xymIHPJm6WXrYaWB/GvK6bMm8V3Kl4STcpY2qAO102DM6wEHsn7qtjbfwLp1+mC8ka8CoglWcugQ==} engines: {node: '>=8.0.0'} dependencies: '@azure/core-http': 2.2.1 @@ -9052,12 +9052,12 @@ packages: dev: false file:projects/communication-chat.tgz: - resolution: {integrity: sha512-hwiUYIKo2uze93jsrAMKE3tCLOj/s3JiffASzXFcXMNMzzXJT0ikVatL0u0MZXaplZHFyMcHJ1/tjCuSQE9Cew==, tarball: file:projects/communication-chat.tgz} + resolution: {integrity: sha512-3mBDemL2PvS7+J1J+I6rvF0FDpoN5BKfpISDGwz+7vbCTKOBa1Wrnp6OfdaXyT7clZ0vTdzAxbz0JN/MdWnM7w==, tarball: file:projects/communication-chat.tgz} name: '@rush-temp/communication-chat' version: 0.0.0 dependencies: '@azure/communication-identity': 1.0.0 - '@azure/communication-signaling': 1.0.0-beta.10 + '@azure/communication-signaling': 1.0.0-beta.11 '@azure/core-tracing': 1.0.0-preview.13 '@microsoft/api-extractor': 7.18.13 '@rollup/plugin-commonjs': 11.0.2_rollup@1.32.1 diff --git a/sdk/communication/communication-chat/CHANGELOG.md b/sdk/communication/communication-chat/CHANGELOG.md index f5dccbe6dbbd..fe6f26a353a0 100644 --- a/sdk/communication/communication-chat/CHANGELOG.md +++ b/sdk/communication/communication-chat/CHANGELOG.md @@ -1,6 +1,12 @@ # Release History -## 1.1.0 ((2021-09-15) +## 1.1.1 (Not released) + +### Features Added +- Updated to @azure/communication-signaling@1.0.0-beta.11. +- Added `signalingClientOptions` in `ClientOptions`. + +## 1.1.0 (2021-09-15) ### Features Added diff --git a/sdk/communication/communication-chat/package.json b/sdk/communication/communication-chat/package.json index 4925bd21f719..571b2bd5af65 100644 --- a/sdk/communication/communication-chat/package.json +++ b/sdk/communication/communication-chat/package.json @@ -1,6 +1,6 @@ { "name": "@azure/communication-chat", - "version": "1.1.0", + "version": "1.1.1", "description": "Azure client library for Azure Communication Chat services", "sdk-type": "client", "main": "dist/index.js", @@ -65,7 +65,7 @@ "dependencies": { "@azure/abort-controller": "^1.0.0", "@azure/communication-common": "^1.1.0", - "@azure/communication-signaling": "1.0.0-beta.10", + "@azure/communication-signaling": "1.0.0-beta.11", "@azure/core-auth": "^1.3.0", "@azure/core-client": "^1.0.0", "@azure/core-rest-pipeline": "^1.1.0", diff --git a/sdk/communication/communication-chat/src/chatClient.ts b/sdk/communication/communication-chat/src/chatClient.ts index 93984cb4c3a5..d21165d9e190 100644 --- a/sdk/communication/communication-chat/src/chatClient.ts +++ b/sdk/communication/communication-chat/src/chatClient.ts @@ -85,7 +85,11 @@ export class ChatClient { const authPolicy = createCommunicationTokenCredentialPolicy(this.tokenCredential); this.client.pipeline.addPolicy(authPolicy); - this.signalingClient = getSignalingClient(credential, logger); + this.signalingClient = getSignalingClient( + credential, + logger, + (options as any).signalingClientOptions + ); } /** @@ -238,7 +242,7 @@ export class ChatClient { } this.isRealtimeNotificationsStarted = true; - this.signalingClient.start(); + await this.signalingClient.start(); this.subscribeToSignalingEvents(); } @@ -252,7 +256,7 @@ export class ChatClient { } this.isRealtimeNotificationsStarted = false; - this.signalingClient.stop(); + await this.signalingClient.stop(); this.emitter.removeAllListeners(); } diff --git a/sdk/communication/communication-chat/src/signaling/signalingClient.browser.ts b/sdk/communication/communication-chat/src/signaling/signalingClient.browser.ts index 4063a810ed48..531afb842581 100644 --- a/sdk/communication/communication-chat/src/signaling/signalingClient.browser.ts +++ b/sdk/communication/communication-chat/src/signaling/signalingClient.browser.ts @@ -4,10 +4,14 @@ import { CommunicationSignalingClient, SignalingClient } from "@azure/communication-signaling"; import { CommunicationTokenCredential } from "@azure/communication-common"; import { AzureLogger } from "@azure/logger"; +import { SignalingClientOptions } from "./signalingClient"; export const getSignalingClient = ( credential: CommunicationTokenCredential, - logger: AzureLogger + logger: AzureLogger, + options?: SignalingClientOptions ): SignalingClient | undefined => { - return new CommunicationSignalingClient(credential, logger); + return new CommunicationSignalingClient(credential, logger, { + environment: options?.environment ?? undefined + }); }; diff --git a/sdk/communication/communication-chat/src/signaling/signalingClient.ts b/sdk/communication/communication-chat/src/signaling/signalingClient.ts index 2128c5141b36..a684e702c5db 100644 --- a/sdk/communication/communication-chat/src/signaling/signalingClient.ts +++ b/sdk/communication/communication-chat/src/signaling/signalingClient.ts @@ -5,13 +5,20 @@ import { CommunicationSignalingClient, SignalingClient } from "@azure/communicat import { CommunicationTokenCredential } from "@azure/communication-common"; import { AzureLogger } from "@azure/logger"; +export interface SignalingClientOptions { + environment?: string; +} + export const getSignalingClient = ( credential: CommunicationTokenCredential, - logger: AzureLogger + logger: AzureLogger, + options?: SignalingClientOptions ): SignalingClient | undefined => { if (typeof navigator !== "undefined" && navigator.product === "ReactNative") { // In React Native - return new CommunicationSignalingClient(credential, logger); + return new CommunicationSignalingClient(credential, logger, { + environment: options?.environment ?? undefined + }); } // In node js