[storage][datalake] uploadFile does not abort when timeout

[ljian3377]

azure-sdk-for-js/sdk/storage/storage-file-datalake/test/node/highlevel.node.spec.ts

Line 488 in 752628b

it("uploadFile with chunkSize = FILE_UPLOAD_MAX_CHUNK_SIZE should succeed", async () => {

I expected the timeout aborter could abort the uploadFile operation. But it doesn't. The 4GB upload hasn't done yet after 6 minutes. We passed the abortSignal to underlying requests so what's going wrong? @XiaoningLiu @jeremymeng

azure-sdk-for-js/sdk/storage/storage-file-datalake/src/clients.ts

Line 1483 in 752628b

abortSignal: options.abortSignal,

  it("uploadFile with chunkSize = FILE_UPLOAD_MAX_CHUNK_SIZE should succeed", async () => {
    recorder.skip("node", "Temp file - recorder doesn't support saving the file");
    const fileSize = FILE_UPLOAD_MAX_CHUNK_SIZE * 2 + MB;
    const tempFile = await createRandomLocalFile(tempFolderPath, fileSize / MB, MB);
    try {
      await fileClient.uploadFile(tempFile, {
        chunkSize: FILE_UPLOAD_MAX_CHUNK_SIZE,
        abortSignal: AbortController.timeout(20 * 1000) // takes too long to upload the file
      });
    } catch (err) {
      assert.equal(err.name, 'AbortError');
    }

    fs.unlinkSync(tempFile);
  }).timeout(timeoutForLargeFileUploadingTest);

azure:storage-file-datalake:info Request: {
  "streamResponseBody": false,
  "url": "https://jsv12.dfs.core.windows.net/filesystem159593998218302360/file159593998381509579?position=REDACTED&action=REDACTED",
  "method": "PATCH",
  "headers": {
    "_headersMap": {
      "content-length": "4194304000",
      "x-ms-version": "2019-12-12",
      "user-agent": "azsdk-js-storagedatalake/12.1.0 (NODE-VERSION v12.13.0; Windows_NT 10.0.19041)",
      "x-ms-client-request-id": "f3ad7dd1-2f1a-4a60-a064-06d0d0a6821d"
    }
  },
  "withCredentials": false,
  "timeout": 0,
  "keepAlive": true,
  "requestId": "f3ad7dd1-2f1a-4a60-a064-06d0d0a6821d"
}
azure:storage-file-datalake:info RetryPolicy: =====> Try=1 Primary
azure:storage-file-datalake:info Request: {
  "streamResponseBody": false,
  "url": "https://jsv12.dfs.core.windows.net/filesystem159593998218302360/file159593998381509579?position=REDACTED&action=REDACTED",
  "method": "PATCH",
  "headers": {
    "_headersMap": {
      "content-length": "1048576",
      "x-ms-version": "2019-12-12",
      "user-agent": "azsdk-js-storagedatalake/12.1.0 (NODE-VERSION v12.13.0; Windows_NT 10.0.19041)",
      "x-ms-client-request-id": "dac08a48-bb53-46f3-bb0a-e06cd04764b2"
    }
  },
  "withCredentials": false,
  "timeout": 0,
  "keepAlive": true,
  "requestId": "dac08a48-bb53-46f3-bb0a-e06cd04764b2"
}
azure:storage-file-datalake:info Response status code: 202
azure:storage-file-datalake:info Headers: {
  "_headersMap": {
    "content-length": "0",
    "date": "Tue, 28 Jul 2020 12:39:49 GMT",
    "server": "Windows-Azure-HDFS/1.0 Microsoft-HTTPAPI/2.0",
    "x-ms-client-request-id": "dac08a48-bb53-46f3-bb0a-e06cd04764b2",
    "x-ms-request-id": "0cb03dee-501f-0071-14dc-6437a7000000",
    "x-ms-request-server-encrypted": "true",
    "x-ms-version": "2019-12-12"
  }
}

[jeremymeng]

I think this is the same issue in #12029. We remove the abort event handler after receiving response, instead of waiting for streaming to complete.

[jeremymeng]

timeout should trigger abortSignal now.