Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified Recorder] Work on the No-op AAD credential for playback - to be in sync with .NET and Python #18897

Closed
Tracked by #15829
HarshaNalluru opened this issue Dec 1, 2021 · 0 comments · Fixed by #18904
Assignees
Labels
test-utils-recorder Label for the issues related to the common recorder

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Dec 1, 2021

If the AAD credentials don't take the recorder httpClient option, the AAD traffic won't be recorded.
In this case, you'll need to bypass the AAD requests with no-op in playback(since there are no recorded requests to match).
This PR provides the No-op AAD credential for playback.

The current plan is to provide both ways of recording the tests

  • NoOp credential [App Config] Migrate the tests to use the new unified recorder #18896 - where the services/SDKs don't care about the AAD traffic
    • .NET and Python follows this model for all their services/SDKs
  • RecorderHttpClient for AAD - Harshan/unified recorder/migrate app config #18898 - for the Services/SDKs that would want to see the AAD traffic in their tests
    • We had seen some value in recording the AAD traffic with the old recorder(in JS).
    • This has particularly helped us uncover multiple bugs in the token refreshing space where we regressed and started making more requests than expected.
    • Also helped us see how the msal has been changing over time w.r.t its request bodies.
    • We are waiting for a special kind of matcher from the proxy tool side to complete the missing pieces in this area.
    • This is exclusive for JS.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 1, 2021
@HarshaNalluru HarshaNalluru changed the title Work on the No-op AAD credential for playback - to be in sync with .NET and Python [Unified Recorder] Work on the No-op AAD credential for playback - to be in sync with .NET and Python Dec 1, 2021
@HarshaNalluru HarshaNalluru self-assigned this Dec 1, 2021
@HarshaNalluru HarshaNalluru added the test-utils-recorder Label for the issues related to the common recorder label Dec 1, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 1, 2021
@HarshaNalluru HarshaNalluru added this to the [2022] January milestone Dec 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test-utils-recorder Label for the issues related to the common recorder
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant