Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified Recorder] dotenv - load it by default from recorder-new #19140

Closed
Tracked by #15829
HarshaNalluru opened this issue Dec 10, 2021 · 1 comment · Fixed by #19139
Closed
Tracked by #15829

[Unified Recorder] dotenv - load it by default from recorder-new #19140

HarshaNalluru opened this issue Dec 10, 2021 · 1 comment · Fixed by #19139
Assignees
@HarshaNalluru
Labels
test-utils-recorder Label for the issues related to the common recorder
Milestone
[2022] January

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Dec 10, 2021 •
edited
Loading

Instead of loading env after the recorder.start() like we have with the current recorder, load the .env file as soon as before actually running the tests.
@HarshaNalluru HarshaNalluru mentioned this issue Dec 10, 2021
Closed
97 tasks
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 10, 2021
@HarshaNalluru HarshaNalluru changed the title dotenv - load it by default from recorder-new [Unified Recorder] dotenv - load it by default from recorder-new Dec 10, 2021
@HarshaNalluru HarshaNalluru added the test-utils-recorder Label for the issues related to the common recorder label Dec 10, 2021
@HarshaNalluru HarshaNalluru self-assigned this Dec 10, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 10, 2021
@HarshaNalluru HarshaNalluru added this to the [2022] January milestone Dec 10, 2021
@HarshaNalluru HarshaNalluru mentioned this issue Dec 10, 2021
Merged
@HarshaNalluru
Copy link
Member Author

#19139

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HarshaNalluru HarshaNalluru

Labels
test-utils-recorder Label for the issues related to the common recorder
Projects
None yet
Milestone
[2022] January
Development

Successfully merging a pull request may close this issue.

[Unified Recorder] Load the env file by default HarshaNalluru/azure-sdk-for-js
1 participant
@HarshaNalluru