Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency package @types/concurrently has a new version available #19880

Closed
azure-sdk opened this issue Jan 17, 2022 · 5 comments
Closed

Dependency package @types/concurrently has a new version available #19880

azure-sdk opened this issue Jan 17, 2022 · 5 comments
Labels
Client This issue points to a problem in the data-plane of the library. dependency-upgrade-required dev-tool Issues related to the Azure SDK for JS dev-tool help wanted This issue is tracking work for which community contributions would be welcomed and appreciated

Comments

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 17, 2022 •
edited
Loading

We have identified a dependency on version 6.4.0 of @types/concurrently. A new version (7.0.0) is available for upgrade.

Following are the steps to upgrade package dependency.

  1. Understand the breaking changes between the version being used and the version you want to upgrade to.

  2. Identify all packages that take a dependency on this package.

  3. Go to the root folder for each such package (/sdk/service-name/package-name) and update package.json to have the new version.

  4. Run rush update to ensure the new version is pulled in.

  5. Make relevant changes to absorb the breaking changes.

  6. Repeat steps 3 to 5 for each of the packages that have a dependency on this package.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 17, 2022
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jan 18, 2022 •
edited
Loading

@deyaaeldeen I believe this is coming from the test utils in dev-tool

Can you add some pointers on how to test this change and add the help-wanted label?

@ramya-rao-a ramya-rao-a added this to the [2022] March milestone Jan 18, 2022
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. dev-tool Issues related to the Azure SDK for JS dev-tool labels Jan 18, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 18, 2022
@deyaaeldeen deyaaeldeen added the help wanted This issue is tracking work for which community contributions would be welcomed and appreciated label Jan 18, 2022
@deyaaeldeen
Copy link
Member

@ramya-rao-a done!

@jeremymeng
Copy link
Member

It's strange that we didn't get an issue created for the library package concurrently whose latest is 7.0.0. I checked and it is not reported by rush.

Anyway, we should upgrade the @types dependency together with the library dependency.

@jeremymeng jeremymeng mentioned this issue Jan 18, 2022
Closed
@jeremymeng
Copy link
Member

btw logged a rush issue microsoft/rushstack#3169

@azure-sdk azure-sdk removed help wanted This issue is tracking work for which community contributions would be welcomed and appreciated Client This issue points to a problem in the data-plane of the library. dev-tool Issues related to the Azure SDK for JS dev-tool labels Feb 7, 2022
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. help wanted This issue is tracking work for which community contributions would be welcomed and appreciated dev-tool Issues related to the Azure SDK for JS dev-tool labels Mar 9, 2022
@maorleger maorleger modified the milestones: [2022] March, Backlog Apr 4, 2022
@mpodwysocki mpodwysocki mentioned this issue Apr 4, 2022
Merged
3 tasks
@mpodwysocki
Copy link
Member

Closing as per #21186

@xirzec xirzec removed this from the Backlog milestone May 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. dependency-upgrade-required dev-tool Issues related to the Azure SDK for JS dev-tool help wanted This issue is tracking work for which community contributions would be welcomed and appreciated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@xirzec @maorleger @deyaaeldeen @jeremymeng @mpodwysocki @ramya-rao-a @azure-sdk