Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recorder] Test proxy and the ports #22059

Closed
HarshaNalluru opened this issue Jun 1, 2022 · 3 comments
Closed

[Recorder] Test proxy and the ports #22059

HarshaNalluru opened this issue Jun 1, 2022 · 3 comments
Assignees
Labels
test-utils-recorder Label for the issues related to the common recorder
Milestone

Comments

@HarshaNalluru
Copy link
Member

Recorder from the @azure-tools/test-recorder v2 package expects the test-proxy tool is run at the ports 5000 and 5001 (HTTP and HTTPS respectively).

It works because all the following commands run the test-proxy tool at those ports by default

  • dev-tool run test:node-js-input
  • dev-tool run test:node-ts-input
  • dev-tool run test:browser
  • docker run -v /workspaces/azure-sdk-for-js/:/srv/testproxy -p 5001:5001 -p 5000:5000 azsdkengsys.azurecr.io/engsys/testproxy-lin:latest
  • test-proxy --storage-location

However, if the 5000 port is blocked on a client machine, they won't be able to run any of the above commands directly to run the test-proxy tool.
Meaning, the test-proxy tool needs to be run at a different port, but the test-recorder expects the tool runs at 5000, 5001.

TODO:

  • Brainstorm and provide a pattern to remove the hard-coded port in the recorder package,
  • Ports to be dynamic instead
  • Make sure all the commands work in sync with the updates
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 1, 2022
@HarshaNalluru HarshaNalluru added the test-utils-recorder Label for the issues related to the common recorder label Jun 1, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 1, 2022
@HarshaNalluru HarshaNalluru added this to the [2022] June milestone Jun 1, 2022
@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Azure.Core:0.58147585,Storage:0.06634899,Cognitive - Form Recognizer:0.025332628'

@timovv
Copy link
Member

timovv commented Jun 1, 2022

Related: #18240

@HarshaNalluru
Copy link
Member Author

#22145

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test-utils-recorder Label for the issues related to the common recorder
Projects
None yet
Development

No branches or pull requests

3 participants