Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SDK Automation for new code generator #15585

Closed
3 tasks done
weshaggard opened this issue Sep 30, 2020 · 9 comments
Closed
3 tasks done

Enable SDK Automation for new code generator #15585

weshaggard opened this issue Sep 30, 2020 · 9 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. CodeGen Issues that relate to code generation EngSys This issue is impacting the engineering system.

Comments

@weshaggard
Copy link
Member

weshaggard commented Sep 30, 2020

The SDK Automation spec can be found at https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/sdkautomation/sdk_customization.md.

  • Add automation configuration for new code generator in the specs repo
  • Add new swagger_to_sdk configuration file in the language repo
  • Add generate script (./eng/scripts/generate_sdk) that will implement the sdk automations spec.
@weshaggard weshaggard added EngSys This issue is impacting the engineering system. CodeGen Issues that relate to code generation labels Sep 30, 2020
@PhoenixHe-NV
Copy link
Contributor

Hi @weshaggard @pakrym any update on this workitem? I'll make SDK Automation available on test env early next week.

@pakrym pakrym assigned ShivangiReja and unassigned pakrym Oct 16, 2020
@kurtzeborn kurtzeborn added the Client This issue points to a problem in the data-plane of the library. label Nov 11, 2020
@ShivangiReja
Copy link
Member

Track-2 SDK automation is enabled for c#. For more details check- #17193

@ShivangiReja
Copy link
Member

Add automation configuration for new code generator in the specs repo

Here we have added automation configuration in Azure/azure-rest-api-specs repo.

@weshaggard
Copy link
Member Author

@ShivangiReja have any serviced enabled the new generation in the specs repo? I'd like to make sure we have some documentation to point folks at that want to enable that automation and if we don't already we should have an issue (or set of issues) tracking enabling this for those servcies.

cc @AlexGhiondea

@ShivangiReja
Copy link
Member

I'm planning to enable track-2 sdk automation for all the services. If the service is new or the sdk doesn't exists in azure-sdk-for-net repo, it won't affect anything. It will only generate code for existing swagger updates.

@PhoenixHe-NV
Copy link
Contributor

Basically, you need to add "azure-sdk-for-net-track2" under the swagger-to-sdk section for all the readme.md. Do you think you want to have an option in sdk automation to enable it for all the readme.md?

@ShivangiReja
Copy link
Member

Basically, you need to add "azure-sdk-for-net-track2" under the swagger-to-sdk section for all the readme.md

Yes, we need to add "azure-sdk-for-net-track2" in all the readme.md files in order to enable track-2 SDK automation.

Do you think you want to have an option in sdk automation to enable it for all the readme.md?

That would be great but how are you planning to provide that option?

@weshaggard
Copy link
Member Author

@ShivangiReja do you have an issue tracking that work that I can reference? If not can you please create one and we can discuss that plan there?

Also before we start putting the name "azure-sdk-for-net-track2" in a bunch of readme's I'd like to explore a couple options for renaming that first. I left some a comment at https://github.com/Azure/azure-rest-api-specs/pull/12169/files#r558531220.

@ShivangiReja
Copy link
Member

@weshaggard Created an issue here to track this.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. CodeGen Issues that relate to code generation EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

5 participants