Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MetricsAdvisor] Service returns 0 CustomFillValue even if fill type is not CustomValue #16701

Closed
kinelski opened this issue Nov 6, 2020 · 1 comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Cognitive - Metrics Advisor Service This issue points to a problem in the service.
Milestone

Comments

@kinelski
Copy link
Member

kinelski commented Nov 6, 2020

In DataFeedMissingDataPointFillSettings, CustomFillValue is set only when FillMissingPointType is CustomValue. When the fill type is NOT CustomValue, I'd expect the service to not return the CustomFillValue (or return null). However, it returns 0.0.

Note: remove the workaround we did in the internal DataFeedMissingDataPointFillSettings constructor when this is fixed:

CustomFillValue = dataFeedDetail.FillMissingPointType == DataFeedMissingDataPointFillType.CustomValue
    ? dataFeedDetail.FillMissingPointValue
    : null;

Update it to:

CustomFillValue = dataFeedDetail.FillMissingPointValue;
@kinelski kinelski added bug This issue requires a change to an existing behavior in the product in order to be resolved. Service This issue points to a problem in the service. Cognitive - Metrics Advisor labels Nov 6, 2020
@kinelski kinelski added this to the Backlog milestone Nov 6, 2020
@kinelski kinelski added the blocking-release Blocks release label Apr 19, 2021
@kinelski kinelski modified the milestones: Backlog, [2021] May Apr 19, 2021
@kinelski kinelski removed the blocking-release Blocks release label Apr 19, 2021
@kinelski kinelski modified the milestones: [2021] May, [2021] June May 7, 2021
@kinelski kinelski added the blocking-release Blocks release label Jun 10, 2021
@kinelski kinelski modified the milestones: [2021] June, [2021] July Jun 10, 2021
@kinelski kinelski removed the blocking-release Blocks release label Jul 9, 2021
@kinelski kinelski modified the milestones: [2021] July, [2021] August Jul 9, 2021
@jsquire jsquire modified the milestones: [2021] September, Backlog Sep 15, 2021
@kinelski
Copy link
Member Author

Service issue. Closing this since it's not related to the SDK.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Cognitive - Metrics Advisor Service This issue points to a problem in the service.
Projects
None yet
Development

No branches or pull requests

2 participants