Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable FxCop Analyzers #17022

Closed
heaths opened this issue Nov 17, 2020 · 2 comments · Fixed by #17157
Closed

Enable FxCop Analyzers #17022

heaths opened this issue Nov 17, 2020 · 2 comments · Fixed by #17157
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.

Comments

@heaths
Copy link
Member

heaths commented Nov 17, 2020

Building on #7467, we should enable FxCop analyers: https://docs.microsoft.com/visualstudio/code-quality/install-fxcop-analyzers. Not only is this recommended by TwC but it allows us to catch things like catch (Exception ex) { /* do stuff */ throw ex; } (CA2200).

To note, some of this can be enabled via our existing .editorconfig: https://docs.microsoft.com/dotnet/fundamentals/code-analysis/code-quality-rule-options

@heaths heaths added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. labels Nov 17, 2020
@heaths
Copy link
Member Author

heaths commented Nov 18, 2020

We might start with .NET's https://github.com/dotnet/runtime/blob/master/eng/CodeAnalysis.ruleset since we started with their .editorconfig as well (with 1 small tweak I don't remember).

@pakrym
Copy link
Contributor

pakrym commented Nov 23, 2020

Update the package to the latest version.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants