Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate removing IDisposable interface from TokenCache #17124

Closed
schaabs opened this issue Nov 20, 2020 · 0 comments · Fixed by #18346
Closed

Investigate removing IDisposable interface from TokenCache #17124

schaabs opened this issue Nov 20, 2020 · 0 comments · Fixed by #18346
Assignees
@christothes
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Milestone
[2021] February

Comments

@schaabs
Copy link
Member

schaabs commented Nov 20, 2020

The TokenCache class currently implements IDisposable to dispose of an underlying SemaphoreSlim. It's possible that this is unnecessary if it is not accessing the underlying WaitHandle. See the discussion here: #17083 (comment).
@schaabs schaabs added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Nov 20, 2020
@schaabs schaabs added this to the [2021] January milestone Nov 20, 2020
@schaabs schaabs mentioned this issue Nov 20, 2020
Merged
@christothes christothes mentioned this issue Feb 2, 2021
Merged
@christothes christothes self-assigned this Feb 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christothes christothes

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2021] February
Development

Successfully merging a pull request may close this issue.

Remove IDisposable from TokenCache christothes/azure-sdk-for-net
3 participants
@jsquire @christothes @schaabs