Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider whether OperationInternalBase.ApplyStateAsync should throw #25628

Closed
heaths opened this issue Dec 2, 2021 · 3 comments
Closed

Consider whether OperationInternalBase.ApplyStateAsync should throw #25628

heaths opened this issue Dec 2, 2021 · 3 comments
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone

Comments

@heaths
Copy link
Member

heaths commented Dec 2, 2021

As discussed, we should consider whether ApplyStateAsync should throw, given that our existing LRO contract was that UpdateStatus and UpdateStatusAsync should not throw; however, if LROs have no Value property, where else would we throw?

/cc @pakrym @AlexanderSher

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 2, 2021
@pakrym
Copy link
Contributor

pakrym commented Dec 2, 2021

cc @kinelski

@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. KeyVault labels Dec 2, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 2, 2021
@heaths heaths added this to the Backlog milestone Oct 24, 2022
@pallavit pallavit assigned heaths and unassigned heaths Dec 7, 2022
@pallavit
Copy link
Contributor

pallavit commented Dec 7, 2022

@heaths if I am not mistaken this is not specific to KV and is a behavior change question on the shared code?

@heaths
Copy link
Member Author

heaths commented Dec 7, 2022

Looking through the code, this seems no longer relevant since KV is using the operation helpers and other common infrastructure.

@heaths heaths closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
Archived in project
Development

No branches or pull requests

4 participants