Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing: Adopt OpenTelemetry error.type attribute for logical calls #39430

Closed
Tracked by #39432
lmolkova opened this issue Oct 20, 2023 · 0 comments · Fixed by #39617
Closed
Tracked by #39432

Tracing: Adopt OpenTelemetry error.type attribute for logical calls #39430

lmolkova opened this issue Oct 20, 2023 · 0 comments · Fixed by #39617
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. Mgmt This issue is related to a management-plane library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)

Comments

@lmolkova
Copy link
Member

Library name

Azure.Core

Please describe the feature.

OTel defined error.type attribute we can use to report low-cardinality failures with.

We can just add it in

public void Failed(Exception? exception = default)

public void Failed(Exception? exception = default)
{
    if (exception != null)
    {
        AddAttribute("error.type", exception.GetType().FullName);
    }

    _activityAdapter?.MarkFailed(exception);
}

(as long as it does not conflict with HTTP-level error.type we're going to set in #39429)

@lmolkova lmolkova added Azure.Core OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific) labels Oct 20, 2023
@lmolkova lmolkova mentioned this issue Oct 20, 2023
10 tasks
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Mgmt This issue is related to a management-plane library. labels Oct 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. Mgmt This issue is related to a management-plane library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants