Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Messaging tracing: support disabling per-message tracing #43355

Open
lmolkova opened this issue Apr 11, 2024 · 1 comment
Open
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific) Service Bus
Milestone

Comments

@lmolkova
Copy link
Member

lmolkova commented Apr 11, 2024

Library name

Azure.Messaging.EventHubs, Azure.Messaging.ServiceBus

Please describe the feature.

We had a several questions/issues from users who didn't like message+send spans. In case there is just one message in a batch, then having two spans does not bring any value.
Also, when batch size it huge, per-message tracing becomes too hard and might not make sense.

OTel semconv allow to create a span per message in a batch and a publish span OR create one publish span and reuse publish context on each message being published.

We can do the following:

  1. if user enabled per-message source, then we'll create span per message
    • if sender source is enabled, we'll also create a publish span - this existing path, no changes are expected
  2. if user didn't enable per-message source, we won't create a span per message
    • if sender source is enabled, we'll create a publish span:
      • if some message have pre-existing context provided by user, we won't update it and will link to it
      • otherwise, we'll inject publish span context into the message
      • this is the new feature
  • if sender source is not enabled - no tracing or context propagation happens - same as before.
@lmolkova lmolkova added Service Bus Event Hubs Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific) labels Apr 11, 2024
@github-actions github-actions bot added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Apr 11, 2024
Copy link

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@lmolkova lmolkova assigned lmolkova and unassigned JoshLove-msft Apr 11, 2024
@jsquire jsquire removed the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Apr 11, 2024
@lmolkova lmolkova added this to the 2024-05 milestone Apr 11, 2024
@jsquire jsquire modified the milestones: 2024-05, 2024-06 May 20, 2024
@jsquire jsquire modified the milestones: 2024-06, Backlog Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific) Service Bus
Projects
None yet
Development

No branches or pull requests

3 participants