Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiapi_init_gen.py generate unmatched code on azure-mgmt-resource #10621

Closed
changlong-liu opened this issue Apr 2, 2020 · 6 comments
Closed
Assignees
Labels
Mgmt This issue is related to a management-plane library.

Comments

@changlong-liu
Copy link
Member

  • Package Name:
  • Package Version:
  • Operating System:
  • Python Version:

Describe the bug
Swagger version: Azure/azure-rest-api-specs#8268

Below is the _resource_management_client.py in azure.mgmt.resource.resources
image

It is calling ResourceManagementClientConfiguration with parameter subscription_id.
But in the _configuration.py, ResourceManagementClientConfiguration actually require both subscription_id and subscription_id1
image

To Reproduce
Steps to reproduce the behavior:
use packaging_tools.generate_sdk

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@kaerm kaerm added the Mgmt This issue is related to a management-plane library. label Apr 2, 2020
@triage-new-issues triage-new-issues bot removed the triage label Apr 2, 2020
@kaerm
Copy link
Contributor

kaerm commented Apr 2, 2020

Thanks @changlong-liu, @nickzhums can you take a look at this

@RodgeFu
Copy link
Member

RodgeFu commented Apr 7, 2020

@lmazuel to check the issue in generated code. thanks.

@lmazuel
Copy link
Member

lmazuel commented Apr 7, 2020

subscription_id1 is likely the root cause of the issue in the first place. That doesn't seem right, likely a Swagger issue. @zikalino FYI

@changlong-liu
Copy link
Member Author

Hi @chenjianfei2017 , would you help to confirm this is fixed in swagger? Thanks.

@chenjianfei2017
Copy link
Contributor

@changlong-liu
Copy link
Member Author

Thanks @chenjianfei2017 !

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

No branches or pull requests

5 participants