Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AZURE_AUTHORITY_HOST does not allow URI scheme to be specified #10819

Closed
jongio opened this issue Apr 14, 2020 · 3 comments · Fixed by #11050
Closed

AZURE_AUTHORITY_HOST does not allow URI scheme to be specified #10819

jongio opened this issue Apr 14, 2020 · 3 comments · Fixed by #11050
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.

Comments

@jongio
Copy link
Member

jongio commented Apr 14, 2020

In latest preview,

If I specify the AZURE_AUTHORITY_HOST environment variable with scheme (https)
AZURE_AUTHORITY_HOST=https://login.microsoftonline.us

I get the following exception:
DefaultAzureCredential failed to retrieve a token from the included credentials. Attempted credentials: EnvironmentCredential: <urllib3.connection.VerifiedHTTPSConnection object at 0x0000020F404EDCA0>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed

It works if I do not provide a scheme
AZURE_AUTHORITY_HOST=login.microsoftonline.us

All other Azure SDK languages support specifying a URI scheme for AZURE_AUTHORITY_HOST.

Please update the Python implementation to allow the user to specify a scheme.

@jongio
Copy link
Member Author

jongio commented Apr 14, 2020

It would be great if this was implemented for the authorityHost property as well, because all the other langs allow it there as well.

@lmazuel lmazuel added Azure.Identity Client This issue points to a problem in the data-plane of the library. labels Apr 14, 2020
@jongio
Copy link
Member Author

jongio commented Apr 29, 2020

FYI - I verified this with my manual tests against Azure Gov and it passed. Thank you for getting this in.

@chlowell
Copy link
Member

Great, thanks for testing it.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants