Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ServiceBus] Track2- Support SAS tokens for ServiceBus within Connection String #13407

Closed
KieranBrantnerMagee opened this issue Aug 28, 2020 · 0 comments · Fixed by #13627
Closed

[ServiceBus] Track2- Support SAS tokens for ServiceBus within Connection String #13407

KieranBrantnerMagee opened this issue Aug 28, 2020 · 0 comments · Fixed by #13627
Assignees
@KieranBrantnerMagee
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Milestone
[2020] September

Comments

@KieranBrantnerMagee
Copy link
Member

Currently connection string does not support SAS tokens. This functionality is currently being added to eventhub here.

Almost the exact same approach as above is needed here, in terms of parsing the sharedaccesstoken field from the connstr and utilizing that, extracting the se= field for expiry if present and setting a sane fallback if not.

Tests, docs, the whole deal.
@KieranBrantnerMagee KieranBrantnerMagee added Service Bus Client This issue points to a problem in the data-plane of the library. help wanted This issue is tracking work for which community contributions would be welcomed and appreciated labels Aug 28, 2020
@KieranBrantnerMagee KieranBrantnerMagee added this to the [2020] September milestone Aug 28, 2020
@KieranBrantnerMagee KieranBrantnerMagee changed the title [ServiceBus] Track2- Support SAS ktokens for ServiceBus within Connection String [ServiceBus] Track2- Support SAS tokens for ServiceBus within Connection String Aug 28, 2020
@KieranBrantnerMagee KieranBrantnerMagee removed the help wanted This issue is tracking work for which community contributions would be welcomed and appreciated label Sep 8, 2020
@KieranBrantnerMagee KieranBrantnerMagee mentioned this issue Sep 8, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KieranBrantnerMagee KieranBrantnerMagee

Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Milestone
[2020] September
1 participant
@KieranBrantnerMagee