Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eventhub checkpointstoreblob Readme and Samples issues #16341

Closed
v-xuto opened this issue Jan 26, 2021 · 1 comment
Closed

Eventhub checkpointstoreblob Readme and Samples issues #16341

v-xuto opened this issue Jan 26, 2021 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. Docs Event Hubs needs-team-triage Workflow: This issue needs the team to triage.
Milestone
[2021] February

Comments

@v-xuto
Copy link
Member

v-xuto commented Jan 26, 2021

  1. Section link:
    image

Suggestion:
Refer to this section of other service Readme, for example :
https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/storage/azure-storage-file-datalake#more-sample-code
It is recommended to update as shown in the figure below:
image

Section link1,link2:
image

Reason:
ValueError: The eventhub name can not be None or empty.

Suggestion:
Add a comment to CONNECTION_STR # connection string contains EventHub name.
Or
Add eventhub_name=eventhub_name , uptate to:

client = EventHubConsumerClient.from_connection_string(
    CONNECTION_STR,
    "$Default",
    eventhub_name=eventhub_name,
    checkpoint_store=checkpoint_store
)

@jongio for notification.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 26, 2021
@tzhanl tzhanl added Client This issue points to a problem in the data-plane of the library. Docs Event Hubs manual-test-pass needs-team-triage Workflow: This issue needs the team to triage. labels Jan 26, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 26, 2021
@yunhaoling yunhaoling mentioned this issue Feb 1, 2021
Merged
@yunhaoling
Copy link
Contributor

thanks @v-xuto , doc/sample fix PR merged: #16457

@yunhaoling yunhaoling added this to the [2021] February milestone Mar 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Docs Event Hubs needs-team-triage Workflow: This issue needs the team to triage.
Projects
None yet
Milestone
[2021] February
Development

No branches or pull requests
3 participants
@tzhanl @yunhaoling @v-xuto