Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable pylint on azure-eventhub #18986

Closed
scbedd opened this issue May 27, 2021 · 3 comments · Fixed by #21855
Closed

Re-enable pylint on azure-eventhub #18986

scbedd opened this issue May 27, 2021 · 3 comments · Fixed by #21855
Assignees
@swathipil
Labels
Client This issue points to a problem in the data-plane of the library. Messaging Messaging crew MQ This issue is part of a "milestone of quality" initiative. P0 Service Bus
Milestone
Backlog

Comments

@scbedd
Copy link
Member

scbedd commented May 27, 2021

azure-servicebus was added to the set of packages that we allow pylint failures on in this PR.

Given that the package is track2, we probably want to re-enable it and fix the pylint at some point. Filing this issue to ensure this isn't lost.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 27, 2021
@scbedd scbedd mentioned this issue May 27, 2021
Merged
@xiangyan99
Copy link
Member

Thank you Scott.

@xiangyan99
Copy link
Member

Sorry. I thought it was fixed in [eventhub] ci fix #18945 :)

@xiangyan99 xiangyan99 reopened this May 27, 2021
@annatisch annatisch added Client This issue points to a problem in the data-plane of the library. Service Bus labels Jun 2, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 2, 2021
@yunhaoling yunhaoling added the Messaging Messaging crew label Sep 13, 2021
@yunhaoling yunhaoling added the MQ This issue is part of a "milestone of quality" initiative. label Oct 5, 2021
@yunhaoling yunhaoling modified the milestones: [2021] December, Backlog Nov 16, 2021
@yunhaoling yunhaoling added the P0 label Nov 16, 2021
@swathipil
Copy link
Member

I believe this should be re-enable pylint on azure-eventhub?

azure-sdk-for-python/eng/tox/allowed_pylint_failures.py

Line 62 in eb96378

"azure-eventhub",

@swathipil swathipil changed the title Re-enable pylint on azure-servicebus Re-enable pylint on azure-eventhub Nov 23, 2021
@swathipil swathipil mentioned this issue Nov 23, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@swathipil swathipil

Labels
Client This issue points to a problem in the data-plane of the library. Messaging Messaging crew MQ This issue is part of a "milestone of quality" initiative. P0 Service Bus
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

[EventHubs] re-enable pylint swathipil/azure-sdk-for-python
5 participants
@annatisch @xiangyan99 @scbedd @yunhaoling @swathipil