Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messaging] Add In Negative Testing #24846

Closed
4 tasks done
kashifkhan opened this issue Jun 14, 2022 · 1 comment
Closed
4 tasks done

[Messaging] Add In Negative Testing #24846

kashifkhan opened this issue Jun 14, 2022 · 1 comment
Assignees
Labels
Messaging Messaging crew
Milestone

Comments

@kashifkhan
Copy link
Member

kashifkhan commented Jun 14, 2022

To maintain parity between exceptions between pyamqp and uamqp add in negative tests to expose behavior/exceptions during a failure.

cases to test:

  • when creating client with DefaultAzureCredential, pass in fully_qualified_namespace=None.
  • In pyamqp: gives us 'can only concatenate str (not "NoneType") to str\ncan only concatenate str (not "NoneType") to str'). This is b/c the AMQPClient._hostname = None, so in def _open, creating Connection object with "amqps://" + self._hostname gives us error.
  • passing None in as sas_policy and key in EventHubSharedKeyCredential
  • in pyamqp, error:
  • in uamqp, error:
  • token auth failure/bad signature:
  • pyamqp:
    azure.eventhub._pyamqp.error.TokenAuthFailure: CBS Token authentication failed.
    Status code: 401
    Description: InvalidSignature: The token has an invalid signature. TrackingId:14e015a9-f58f-44ec-8030-0faf2ec77923, SystemTracker:NoSystemTracker, Timestamp:2022-05-12T16:19:46
  • for uamqp error is: Authentication Put-Token failed. Retries exhausted.
  • for credentials: note that a bad/expired token will be checked during client creation. For pyamqp, it looks like this token failure is not being retried. Need to double check
@kashifkhan kashifkhan added the Messaging Messaging crew label Jun 14, 2022
@kashifkhan kashifkhan added this to the [2022] July milestone Jun 14, 2022
@l0lawrence
Copy link
Member

testing timeout in client.py

@lmazuel lmazuel modified the milestones: 2022-07, 2022-11 Sep 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Messaging Messaging crew
Projects
None yet
Development

No branches or pull requests

4 participants