Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS Recording] Too many /s in the url - is it expected? or a bug? #5296

Closed
HarshaNalluru opened this issue Feb 1, 2023 · 1 comment
Closed
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@HarshaNalluru
Copy link
Member

interesting to see so many /s. /cc @HarshaNalluru @timovv

Originally posted by @jeremymeng in Azure/azure-sdk-for-js#24581 (comment)

In a particular recording in the JS repo for the package azure-developer-center, we see a mysterious URL with too many /s, curious about why that's the case.

It is a low priority as it is not blocking anyone yet, since the pipelines are green.

At a quick glance, it seems santizers/configs set on the recorder look simple and probably should not have caused this.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 1, 2023
@kurtzeborn kurtzeborn added Central-EngSys This issue is owned by the Engineering System team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Feb 6, 2023
@scbedd
Copy link
Member

scbedd commented Feb 22, 2023

Given that this doesn't happen in all cases, and very specifically happens on this test, I think that something is up with your input string or with the sanitizer config @HarshaNalluru .

I will note that Info/Active now allows you to see what is configured for an individual test, as long as you have a breakpoint in your runner before the test stops playback. I don't think there is a generic problem with sanitization.

@scbedd scbedd closed this as completed Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

No branches or pull requests

3 participants