ci: do not use --dirty when generating CI image version and add upgrade job as part of CI
#136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chewong
changed the title
--dirty when generating CI image version …--dirty when generating CI image version
Signed-off-by: Ernest Wong <[email protected]>
aramase
reviewed
Aug 6, 2021
chewong
changed the title
--dirty when generating CI image version--dirty when generating CI image version and add upgrade job as part of CI
aramase
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
kustomize edit set imagecauses the git branch to be in a dirty state, which causes the subsequent e2e test to use a non-existing webhook image.Requirements
Issue Fixed:
Fixes #135
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: