feat: implement proxy using msal-go #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chewong
reviewed
Aug 12, 2021
| @@ -248,14 +252,18 @@ $(E2E_TEST): | |||
| # Ginkgo configurations | |||
| GINKGO_FOCUS ?= | |||
| GINKGO_SKIP ?= | |||
| GINKGO_NODES ?= 3 | |||
| GINKGO_NODES ?= 1 | |||
There was a problem hiding this comment.
Is it not possible to run e2e tests in parallel?
There was a problem hiding this comment.
The proxy test and token exchange test currently use the same service account for tests and running in parallel will cause a race. I can add trust for a new service account and enable parallel again in a follow-up PR.
| klog.InfoS("received token request", "method", r.Method, "uri", r.RequestURI) | ||
| w.Header().Set("Server", version.GetUserAgent("proxy")) | ||
| clientID, resource := parseTokenRequest(r) | ||
| // TODO (aramase) should we fallback to the clientID in the annotated service account |
There was a problem hiding this comment.
Should we implement this in this PR or a follow-up PR?
There was a problem hiding this comment.
This is still up for debate so I didn't want to add this as part of this PR. I'll add a follow-up PR once we make a decision on this.
Signed-off-by: Anish Ramasekar <[email protected]> update token acquire logic Signed-off-by: Anish Ramasekar <[email protected]> test: add e2e tests for proxy Signed-off-by: Anish Ramasekar <[email protected]>
This was referenced Aug 12, 2021
chewong
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anish Ramasekar [email protected]
Reason for Change:
proxy-initandproxyRequirements
Issue Fixed:
fixes #57
fixes #14
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: