Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update verify_deployment_yaml job to use latest image #152

Merged
merged 2 commits into from
Aug 25, 2021
Merged

test: update verify_deployment_yaml job to use latest image #152

merged 2 commits into from
Aug 25, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Aug 25, 2021

Signed-off-by: Anish Ramasekar [email protected]

Reason for Change:

The verify_deployment_yaml nightly tests are failing as the yaml is deployed with an old image that uses a different Kubernetes secret name. We should always validate the manifest_staging yamls with the latest image.

Failing test: https://dev.azure.com/AzureContainerUpstream/Azure%20Workload%20Identity/_build/results?buildId=26069&view=logs&j=15db6f6b-fb5a-571e-0407-f239d4e731ba

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@aramase aramase marked this pull request as ready for review August 25, 2021 06:21
@aramase aramase requested a review from chewong August 25, 2021 16:39
@aramase aramase enabled auto-merge (squash) August 25, 2021 16:47
@aramase aramase merged commit b030fbd into Azure:main Aug 25, 2021
@aramase aramase deleted the fix-verify-deployment-test branch August 25, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants