Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non-existing secrets #93

Open
JeannedArk opened this issue Jun 9, 2023 · 4 comments
Open

Support for non-existing secrets #93

JeannedArk opened this issue Jun 9, 2023 · 4 comments
Labels
idle Inactive for 14 days need-to-triage Requires investigation

Comments

@JeannedArk
Copy link

Hi,

are there any considerations to support deployment of secrets for the first time, i.e. when secrets do not yet exist? I am aware that the documentation says: Create a generic secret or docker-registry secret in Kubernetes cluster, replacing the secret if it already exists.

Currently, using the action in this scenario results in:

Warning: Failed to delete secret with statusCode: 404
Warning: {}
Deleting secret:
undefined
Error: SyntaxError: Unexpected token = in JSON at position 27

IMHO it would be quite useful to support this.

Thanks

@JeannedArk JeannedArk added the need-to-triage Requires investigation label Jun 9, 2023
@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Jun 23, 2023
@bownux
Copy link

bownux commented Sep 28, 2023

I think it is actually deleting the secret and not able to parse the result json.

@github-actions github-actions bot removed the idle Inactive for 14 days label Sep 29, 2023
@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Oct 13, 2023
@PiotrDevCAN
Copy link

Hi, is there any update on this?
I noticed this problem concerns all versions above v2 and secrets that are defined as 'generic'
Assuming, initially, the specific secret doesn't exist, and providing base64 value into the data key, the action fails with the following error:
Warning: Failed to delete secret with statusCode: 404
Warning: {}
Deleting secret:
undefined
Error: SyntaxError: Unexpected token h in JSON at position 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Inactive for 14 days need-to-triage Requires investigation
Projects
None yet
Development

No branches or pull requests

3 participants