Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karpenter sometimes cannot create nodes/NodeClaims for workloads with zone affinity constraints #339

Closed
comtalyst opened this issue May 11, 2024 · 1 comment · Fixed by #340
Assignees
Labels
area/availability-zones Issues or PRs related to availability zones area/nap Issues or PRs related to Node Auto Provisioning (NAP) area/provisioning Issues or PRs related to provisioning (instance provider) kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@comtalyst
Copy link
Collaborator

comtalyst commented May 11, 2024

Version

Karpenter Version: v0.4.0

Kubernetes Version: v1.28.5

Expected Behavior

When deploying a workload with zone affinity constraints such as below and scale-up is required, the scaleup should occur, with both NodeClaims and nodes created to handle the workloads.

preferredDuringSchedulingIgnoredDuringExecution:
- podAffinityTerm:
    labelSelector:
      matchExpressions:
      - key: app
        operator: In
        values:
        - inflate
    topologyKey: topology.kubernetes.io/zone
  weight: 100

Actual Behavior

NodeClaims might not be created, and the error log below might occur:

The NodeClaim "..." is invalid: spec.requirements[3].key: Invalid value: "string": label domain "kubernetes.io" is restricted

The requirements index can be varied.

Steps to Reproduce the Problem

Deploy a deployment with above affinity on a zoned region.

Resource Specs and Logs

See above.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@comtalyst
Copy link
Collaborator Author

Working on it

@comtalyst comtalyst self-assigned this May 11, 2024
@comtalyst comtalyst added kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. area/nap Issues or PRs related to Node Auto Provisioning (NAP) area/provisioning Issues or PRs related to provisioning (instance provider) area/availability-zones Issues or PRs related to availability zones labels May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/availability-zones Issues or PRs related to availability zones area/nap Issues or PRs related to Node Auto Provisioning (NAP) area/provisioning Issues or PRs related to provisioning (instance provider) kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
1 participant