From 808323a99edfc1e735ebc11017e2d4eb88c372d2 Mon Sep 17 00:00:00 2001 From: tallaxes <18728999+tallaxes@users.noreply.github.com> Date: Mon, 13 Nov 2023 23:01:38 +0000 Subject: [PATCH 1/4] fix(bootstrap): remove outdated feature flags --- pkg/providers/imagefamily/bootstrap/aksbootstrap.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/providers/imagefamily/bootstrap/aksbootstrap.go b/pkg/providers/imagefamily/bootstrap/aksbootstrap.go index a2df0c87e..babfb7a60 100644 --- a/pkg/providers/imagefamily/bootstrap/aksbootstrap.go +++ b/pkg/providers/imagefamily/bootstrap/aksbootstrap.go @@ -253,7 +253,6 @@ var ( "--enforce-node-allocatable": "pods", "--event-qps": "0", "--eviction-hard": "memory.available<750Mi,nodefs.available<10%,nodefs.inodesFree<5%", - "--feature-gates": "CSIMigrationAzureFile=true,DelegateFSGroupToCSIDriver=true,RotateKubeletServerCertificate=true", "--image-gc-high-threshold": "85", "--image-gc-low-threshold": "80", "--keep-terminated-pod-volumes": "false", From ba6309c7aa7539cdc0d29080f01c66213ecf15d7 Mon Sep 17 00:00:00 2001 From: tallaxes <18728999+tallaxes@users.noreply.github.com> Date: Tue, 14 Nov 2023 18:43:59 +0000 Subject: [PATCH 2/4] chore: add 1.28 to test matrix, enable coverage --- .github/workflows/ci-test.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci-test.yml b/.github/workflows/ci-test.yml index 3d534edde..22f142f7c 100644 --- a/.github/workflows/ci-test.yml +++ b/.github/workflows/ci-test.yml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - k8sVersion: ["1.25.x", "1.26.x", "1.27.x"] + k8sVersion: ["1.25.x", "1.26.x", "1.27.x", "1.28.x"] env: K8S_VERSION: ${{ matrix.k8sVersion }} steps: @@ -18,7 +18,7 @@ jobs: with: k8sVersion: ${{ matrix.k8sVersion }} - run: K8S_VERSION=${{ matrix.k8sVersion }} make ci-test -# - uses: shogo82148/actions-goveralls@v1 -# if: env.K8S_VERSION == '1.25.x' -# with: -# path-to-profile: coverage.out + - uses: shogo82148/actions-goveralls@v1 + if: env.K8S_VERSION == '1.27.x' + with: + path-to-profile: coverage.out From 10926a6cfaa3aece19fc65cdd6b98c0bf11f8db5 Mon Sep 17 00:00:00 2001 From: tallaxes <18728999+tallaxes@users.noreply.github.com> Date: Tue, 14 Nov 2023 19:48:06 +0000 Subject: [PATCH 3/4] chore: send coverage using goveralls --- .github/workflows/ci-test.yml | 9 +++++---- hack/toolchain.sh | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci-test.yml b/.github/workflows/ci-test.yml index 22f142f7c..ebe1efc8e 100644 --- a/.github/workflows/ci-test.yml +++ b/.github/workflows/ci-test.yml @@ -18,7 +18,8 @@ jobs: with: k8sVersion: ${{ matrix.k8sVersion }} - run: K8S_VERSION=${{ matrix.k8sVersion }} make ci-test - - uses: shogo82148/actions-goveralls@v1 - if: env.K8S_VERSION == '1.27.x' - with: - path-to-profile: coverage.out + - name: Send coverage + env: + COVERALLS_TOKEN: ${{ secrets.GITHUB_TOKEN }} + run: goveralls -coverprofile=covprofile -service=github + diff --git a/hack/toolchain.sh b/hack/toolchain.sh index cd4a62328..030fdf2af 100755 --- a/hack/toolchain.sh +++ b/hack/toolchain.sh @@ -21,6 +21,7 @@ tools() { # go install -tags extended github.com/gohugoio/hugo@v0.110.0 go install golang.org/x/vuln/cmd/govulncheck@v1.0.1 go install github.com/onsi/ginkgo/v2/ginkgo@latest + go install github.com/mattn/goveralls@v0.0.12 if ! echo "$PATH" | grep -q "${GOPATH:-undefined}/bin\|$HOME/go/bin"; then echo "Go workspace's \"bin\" directory is not in PATH. Run 'export PATH=\"\$PATH:\${GOPATH:-\$HOME/go}/bin\"'." From 1892de5f4674e965809ec695ecd7ab07da1311ca Mon Sep 17 00:00:00 2001 From: tallaxes <18728999+tallaxes@users.noreply.github.com> Date: Tue, 14 Nov 2023 20:07:01 +0000 Subject: [PATCH 4/4] chore: send coverage using goveralls --- .github/workflows/ci-test.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci-test.yml b/.github/workflows/ci-test.yml index ebe1efc8e..5f1b4f343 100644 --- a/.github/workflows/ci-test.yml +++ b/.github/workflows/ci-test.yml @@ -19,7 +19,8 @@ jobs: k8sVersion: ${{ matrix.k8sVersion }} - run: K8S_VERSION=${{ matrix.k8sVersion }} make ci-test - name: Send coverage + # should only send converage once https://docs.coveralls.io/parallel-builds + if: matrix.k8sVersion == '1.27.x' env: COVERALLS_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: goveralls -coverprofile=covprofile -service=github - + run: goveralls -coverprofile=coverage.out -service=github