Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Dependency On xml2js to Prevent Prototype Pollution #480

Closed
2 tasks done
Kurt-von-Laven opened this issue Apr 8, 2023 · 2 comments
Closed
2 tasks done

Bump Dependency On xml2js to Prevent Prototype Pollution #480

Kurt-von-Laven opened this issue Apr 8, 2023 · 2 comments

Comments

@Kurt-von-Laven
Copy link

Package Version: 2.6.4

  • nodejs
    • nodejs version: All
    • os name/version: All
  • browser
    • name/version: All

Describe the bug
xml2js <= 0.4.23 contains a recently disclosed high severity security vulnerability. No patched version is available, and xml2js has not seen a release since 2019. The issue in xml2js is Leonidas-from-XIV/node-xml2js#663.

To Reproduce
Steps to reproduce the behavior:

  1. Add a dependency on @azure/ms-rest-js.
  2. Run yarn npm audit --all --recursive, or the equivalent command in your chosen package manager.

Expected behavior
No security vulnerabilities are detected.

Additional context
I suspect other @azure packages also depend on xml2js.

@Kurt-von-Laven
Copy link
Author

xml2js 0.5.0 has been released, and the upstream issue has been closed as fixed, so a bump is probably all that is needed.

@Kurt-von-Laven Kurt-von-Laven changed the title Sever Dependency On xml2js to Prevent Prototype Pollution Bump Dependency On xml2js to Prevent Prototype Pollution Apr 10, 2023
@jeremymeng
Copy link
Member

v2.6.6 has been release with the fix from PR #481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants