Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RestError class no longer matches the instance thrown via botbuilder message sends #490

Open
2 tasks
Hyokune opened this issue Aug 1, 2024 · 1 comment
Open
2 tasks
Assignees

Comments

@Hyokune
Copy link

Hyokune commented Aug 1, 2024

Package Version: 2.7.0

  • nodejs
    • nodejs version: 20
    • os name/version: Linux / macOS
  • browser
    • name/version: N/A

Describe the bug
We are currently using the botbuilder to send message via Microsoft Teams however we are checking the instance of the error to match the RestError provided from here to ensure that we are handling known exceptions from the API.

This seems to have been working fine until this week where the thrown error no longer matches the instance.

To Reproduce
Steps to reproduce the behavior:

  1. Setup CloudAdapter from botbuilder
  2. Send a message to a user who has blocked the MS teams bot, using continueConversationAsync from the adapter
  3. Check the error thrown

Expected behavior
The RestError class instance should match the error thrown via the Rest API

@Hyokune Hyokune changed the title RestError class no longer matches the instance thrown via Rest API RestError class no longer matches the instance thrown via botbuilder message sends Aug 1, 2024
@jeremymeng
Copy link
Member

jeremymeng commented Aug 7, 2024

@Hyokune Seems that botbuilder migrated to use @azure/core-http. Could you try using RestError from @azure/core-http instead?

@jeremymeng jeremymeng self-assigned this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants