Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider keeping order of attributes in models #213

Open
lmazuel opened this issue Jun 9, 2020 · 0 comments
Open

Consider keeping order of attributes in models #213

lmazuel opened this issue Jun 9, 2020 · 0 comments

Comments

@lmazuel
Copy link
Member

lmazuel commented Jun 9, 2020

Right now, attribute_map is using a regular dict, which means items are ordered starting CPython 3.6 (or Python 3.7), but before that they are not.

This is not a concern in JSON, since the order or node are not relevant per JSON spec, however in XML, attribute order does matter. This means in 2.7 or 3.5, serialization order might be random, and might create XML issue.

Exact impact is unclear yet, but worth creating an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant