Adding BFD Enhancements #3838
Adding BFD Enhancements #3838
Conversation
|
link to original PR |
| cmd = cmd + ' interface ' + key_params[2] | ||
| if not data: | ||
| #BFD peer is deleted | ||
| command = "vtysh -c 'configure terminal' -c 'bfd' -c 'no {}'".format(cmd) |
There was a problem hiding this comment.
better to use list. otherwise, the run_command may fail.
| command = command + " -c 'no shutdown'" | ||
| elif param == 'admin_status' and data[param] == 'down': | ||
| command = command + " -c 'shutdown'" | ||
| run_command(command) |
There was a problem hiding this comment.
Please put all this logic into a template and use vtysh -f. Please check other examples.
| + BFD_SET_CLIENT_STATUS(bfd_info->status, status); | ||
| monotime(&tv); | ||
| bfd_info->last_update = tv.tv_sec; | ||
|
|
There was a problem hiding this comment.
Why do we need this change?
There was a problem hiding this comment.
Scenarios where this code change is required:
BFD is un-configured from BGP at remote end.
Neighbour BFD sends ADMIN_DOWN state, but BFD on local side will send
DOWN to BGP, resulting in BGP session DOWN.
Removing BFD session administratively shouldn't bring DOWN BGP session
at local or remote.
BFD is un-configured from BGP or shutdown locally.
BFD will send state DOWN to BGP resulting in BGP session DOWN.
(This is akin to saying do not use BFD for BGP)
Removing BFD session administratively shouldn't bring DOWN BGP session at
local or remote.
|
Abandoning this since FRR code here have moced to newer versions |
|
Hi @SumitAgarwal123, |
- What I did
BFD Enhancements as per HLD
https://github.com/Azure/SONiC/blob/master/doc/bfd/BFD_Enhancement_HLD.md
- How I did it
As explained in HLD, submitting a patch
- How to verify it
Verified on local setup
- Description for the changelog