Remove the configuration of synchronous mode from init_cfg.json #5308
Conversation
src/sonic-config-engine/minigraph.py
Outdated
| @@ -573,7 +574,9 @@ def parse_meta(meta, hname): | |||
| region = value | |||
| elif name == "CloudType": | |||
| cloudtype = value | |||
| return syslog_servers, dhcp_servers, ntp_servers, tacacs_servers, mgmt_routes, erspan_dst, deployment_id, region, cloudtype | |||
| elif name == "SynchronousMode": | |||
There was a problem hiding this comment.
SynchronousMode [](start = 30, length = 15)
The input minigraph.xml has no new field for you to parse. #Closed
There was a problem hiding this comment.
Removed the field parser in minigraph .xml
| @@ -230,7 +230,6 @@ $(info "INCLUDE_SFLOW" : "$(INCLUDE_SFLOW)") | |||
| $(info "INCLUDE_NAT" : "$(INCLUDE_NAT)") | |||
| $(info "INCLUDE_KUBERNETES" : "$(INCLUDE_KUBERNETES)") | |||
| $(info "TELEMETRY_WRITABLE" : "$(TELEMETRY_WRITABLE)") | |||
| $(info "ENABLE_SYNCHRONOUS_MODE" : "$(ENABLE_SYNCHRONOUS_MODE)") | |||
There was a problem hiding this comment.
ENABLE_SYNCHRONOUS_MODE [](start = 8, length = 23)
Just wondering if there is a need to build for async/sync for community members. #ByDesign
There was a problem hiding this comment.
I feel it is not a must as long as we provide the community with the CLI to change the configuration. The users can update the mode after booting up the image, and this scenario should be pretty rare.
| @@ -538,6 +538,9 @@ sudo LANG=C cp $SCRIPTS_DIR/radv.sh $FILESYSTEM_ROOT/usr/local/bin/radv.sh | |||
| # Copy sonic-netns-exec script | |||
| sudo LANG=C cp $SCRIPTS_DIR/sonic-netns-exec $FILESYSTEM_ROOT/usr/bin/sonic-netns-exec | |||
|
|
|||
| # Copy sonic-sync-mode script | |||
| sudo LANG=C cp $SCRIPTS_DIR/sonic-sync-mode $FILESYSTEM_ROOT/usr/bin/sonic-sync-mode | |||
There was a problem hiding this comment.
sonic-sync-mode [](start = 69, length = 15)
Does it make more sense to move this script to sonic-utilities repo? If yes, you don't need to manually install. #Closed
There was a problem hiding this comment.
Moved it to sonic-utilities repo.
files/scripts/sonic-sync-mode
Outdated
| formatter_class=argparse.RawTextHelpFormatter, | ||
| epilog= | ||
| ''' | ||
| **sudo** needed for configuring synchronous mode |
There was a problem hiding this comment.
sudo [](start = 0, length = 8)
Do you mean bold font? It's difficult to read.
There was a problem hiding this comment.
Fixed this and moved the CLI to sonic-utilities repo.
shi-su
changed the title
…c-net#5308) Remove the configuration of synchronous mode from init_cfg.json
- Why I did it
Remove the configuration of synchronous mode from init_cfg.json
- How I did it
Remove the configuration of synchronous mode from init_cfg.json by removing it from the template file.
- How to verify it
I verified it by testing locally with a virtual switch.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)