added aioredis package to snmp container for supporting linkup/down t… #8130
Conversation
Could you explain how aioredis was (will be?) used to support linkup/down and config change traps? |
aioredis is an asynchronous Redis client which the trap infrastructure in SNMP uses. aioredis is more suited for the SNMP sub-agent because it is based on asyncio and asynchronous Redis client is more suited than the synchronous client. Link up/down and config traps are supported using the this trap infrastructure. |
| @@ -44,7 +44,9 @@ RUN locale-gen | |||
| RUN pip3 install --no-cache-dir \ | |||
| hiredis \ | |||
| pyyaml \ | |||
| smbus | |||
| smbus \ | |||
| aioredis==1.3.0 \ | |||
There was a problem hiding this comment.
Why not install the latest version? Is there anything disruptively changed after 1.3.0? #Closed
There was a problem hiding this comment.
We tried with version 2.0.1 and trap generation is not working. We need to debug further to find why its failing.
Version 1.3.0 is working fine.
suresh-rupanagudi
requested review from
xumia,
lguohan,
sujinmkang,
prgeor and
vdahiya12
as code owners
suresh-rupanagudi
force-pushed
the
build_snmp_trap_infra
branch
from
f511871
to
f7d2821
Compare
…uildimage into build_snmp_trap_infra
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…raps
Why I did it
snmp-subagent needs aioredis package to support linkup/down and config change traps.
How I did it
Using aioredis package used for snmp traps support
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
aioredis package is used to generate linkup/down and config change snmp traps
A picture of a cute animal (not mandatory but encouraged)