[TACACS+] Add audisp-tacplus for per-command accounting. #8750
+1,757
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This just draft PR still ongoing. |
|
Not ready for review, publish by mistake, switch back to draft. still need following change:
|
qiluo-msft
reviewed
Sep 18, 2021
qiluo-msft
reviewed
Sep 18, 2021
src/tacacs/audisp/patches/0001-Port-audisp-tacplus-to-sonic.patch
Outdated
Show resolved
Hide resolved
qiluo-msft
previously approved these changes
Nov 25, 2021
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xumia
approved these changes
Nov 26, 2021
|
This PR build break because file permission of build_debian.sh change to 644, so fix this by: |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Nov 30, 2021
liuh-80
added a commit
to liuh-80/sonic-buildimage
that referenced
this pull request
Jul 11, 2023
) This pull request integrate audisp-tacplus to SONiC for per-command accounting. To support TACACS per-command accounting, we integrate audisp-tacplus project to sonic. 1. Add auditd service to SONiC 2. Port and patch audisp-tacplus to SONiC UT with CUnit to cover all new code in usersecret-filter.c Also pass all current UT. N/A Add audisp-tacplus for per-command accounting.
liuh-80
added a commit
to liuh-80/sonic-buildimage
that referenced
this pull request
Jul 11, 2023
) This pull request integrate audisp-tacplus to SONiC for per-command accounting. To support TACACS per-command accounting, we integrate audisp-tacplus project to sonic. 1. Add auditd service to SONiC 2. Port and patch audisp-tacplus to SONiC UT with CUnit to cover all new code in usersecret-filter.c Also pass all current UT. N/A Add audisp-tacplus for per-command accounting.
qiluo-msft
pushed a commit
that referenced
this pull request
Jul 13, 2023
) (#15788) This pull request integrate audisp-tacplus to SONiC for per-command accounting. ##### Work item tracking - Microsoft ADO **(number only)**: 24433713 #### Why I did it To support TACACS per-command accounting, we integrate audisp-tacplus project to sonic. #### How I did it 1. Add auditd service to SONiC 2. Port and patch audisp-tacplus to SONiC #### How to verify it UT with CUnit to cover all new code in usersecret-filter.c Also pass all current UT. #### Tested branch (Please provide the tested image version) Extract tacacs support functions into library, this will share TACACS config file parse code with other project. Also fix memory leak issue in parse config code. - [ ] SONiC.202012-15723.312602-e230e2d3e #### Description for the changelog Add audisp-tacplus for per-command accounting.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request integrate audisp-tacplus to SONiC for per-command accounting.
Why I did it
To support TACACS per-command accounting, we integrate audisp-tacplus project to sonic.
How I did it
How to verify it
UT with CUnit to cover all new code in usersecret-filter.c
Also pass all current UT.
Which release branch to backport (provide reason below if selected)
N/A
Description for the changelog
Add audisp-tacplus for per-command accounting.
A picture of a cute animal (not mandatory but encouraged)