[ACL] enable ACL FC when genereting config from minigraph but disable by default #8908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by default Signed-off-by: Stepan Blyshchak <[email protected]>
Signed-off-by: Stepan Blyshchak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
stepanblyschak
changed the title
|
@bingwang-ms could you please help to review? |
bingwang-ms
reviewed
Oct 19, 2021
Signed-off-by: Stepan Blyshchak <[email protected]>
…image into acl-enable-fc
bingwang-ms
approved these changes
Oct 20, 2021
| 'ACL': { | ||
| 'FLEX_COUNTER_STATUS': 'disable', | ||
| 'FLEX_COUNTER_DELAY_STATUS': 'true', | ||
| 'POLL_INTERVAL': '10000' |
There was a problem hiding this comment.
@stepanblyschak Could you please help? What could be the possible POLL_INTERVAL range?
alexrallen
added a commit
to alexrallen/sonic-buildimage
that referenced
this pull request
Nov 25, 2021
… disable by default (sonic-net#8908)" This reverts commit a2c2d67.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To support ACL counters on Flex Counter Infrastructure.
How I did it
Enable ACL FC in init_cfg and minigraph. Disable when genereting configuration from preset.
How to verify it
Together with depends PRs. Run ACL/Everflow test suite.
DEPENDS ON: sonic-net/sonic-swss-common#533 sonic-net/sonic-sairedis#953 sonic-net/sonic-swss#1943
HLD: sonic-net/SONiC#857
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)