[debian] increment debian compatibility to 10 to enable parallel package build #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 24, 2019 16:24
Signed-off-by: Stepan Blyschak <[email protected]>
build From debhelper man pages: "If neither option is specified, debhelper currently defaults to --parallel in compat 10 (or later) and --no-parallel otherwise." Signed-off-by: Stepan Blyschak <[email protected]>
|
retest this please |
1 similar comment
|
retest this please |
|
probably because of parallelism this will not pass unittests, since mlnx.pl and brcm.pl are not designed to work in parallel, they need to be executed separately, since each of those instances uses vssyncd process to perform tests, and when executed in parallel, it will conflict |
|
how can we solve this issue? |
|
not easy, since single test requires a vssyncd to be present as a process, a clean redis db and so on, is parallelism required for unittests here ? is it getting too slow to execute? or this is just pure cosmetic change to bump debian tool version?, if it's cosmetic change, then parallel run probably can be disabled by some switch |
Signed-off-by: Stepan Blyschak <[email protected]>
kcudnik
approved these changes
Jun 2, 2019
kcudnik
reviewed
Jun 2, 2019
| @@ -3,7 +3,7 @@ AC_CONFIG_MACRO_DIR([m4]) | |||
| AC_CONFIG_SRCDIR([]) | |||
| AC_CONFIG_AUX_DIR(config) | |||
| AM_CONFIG_HEADER(config.h) | |||
| AM_INIT_AUTOMAKE([subdir-objects foreign]) | |||
| AM_INIT_AUTOMAKE([subdir-objects foreign serial-tests]) | |||
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
…age build (sonic-net#461) * fix parallel build Signed-off-by: Stepan Blyschak <[email protected]> * [debian] increment debian compatibility to 10 to enable parallel package build From debhelper man pages: "If neither option is specified, debhelper currently defaults to --parallel in compat 10 (or later) and --no-parallel otherwise." Signed-off-by: Stepan Blyschak <[email protected]> * make tests run serial Signed-off-by: Stepan Blyschak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.