This repository has been archived by the owner on Aug 31, 2022. It is now read-only.
Mgmt reorg -- use translib APIs from sonic-mgmt-common repo #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Removed dependency on sonic-mgmt-framework repo. All translib dependencies now use the new sonic-mgmt-common repo. 2) Cleaned up go dependency download & patching logic in Makefile. All translib and cvl related libraries and patches are now handled in sonic-mgmt-common repo itself. Telemetry Makefile now manages only telemetry specific dependencies.
renukamanavalan
approved these changes
Jun 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
New repo sonic-mgmt-common is introduced for the common translib related code. Now telemetry service should not depend on sonic-mgmt-framework for translib APIs.
- How I did it
Cleaned up go dependency download & patching logic in Makefile. Updated go.mod to pick translib code from sonic-mgmt-common repo. Telemetry Makefile now manages only
telemetry specific dependencies.
- How to verify it
Full build and incremental builds
Basic ACL and interface opreations through REST, KLISH CLI and gNMI
Gotest
- Description for the changelog
Use translib APIs from sonic-mgmt-common repo. Remove dependency on sonic-mgmt-framework.