[generic-config-updater] Add NTP validator #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
qiluo-msft
reviewed
Jun 13, 2022
qiluo-msft
reviewed
Jun 13, 2022
qiluo-msft
approved these changes
Jun 15, 2022
yxieca
pushed a commit
that referenced
this pull request
Jun 17, 2022
What I did When GCU config NTP_SERVER table, its change is not actually taken info effect. Because NTP service is not restarted. So I add NTP service validator and restart service when NTP_SERVER is changed. How I did it When NTP_SERVER table being configured through GCU, the ntp service will restart. How to verify it Run GCU E2E test for NTP_SERVER table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
When GCU config NTP_SERVER table, its change is not actually taken info effect. Because NTP service is not restarted. So I add NTP service validator and restart service when NTP_SERVER is changed.
How I did it
When NTP_SERVER table being configured through GCU, the ntp service will restart.
How to verify it
Run GCU E2E test for NTP_SERVER table.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)