From 4824e8c8e247a7598ee2a128163fcc5eeb4d4279 Mon Sep 17 00:00:00 2001 From: djchen Date: Thu, 1 Dec 2022 21:48:19 -0600 Subject: [PATCH 1/2] change logistics of breaking-change-detect --- .github/workflows/breaking-change-detect.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/breaking-change-detect.yaml b/.github/workflows/breaking-change-detect.yaml index 98a5735..dab4d6f 100644 --- a/.github/workflows/breaking-change-detect.yaml +++ b/.github/workflows/breaking-change-detect.yaml @@ -13,6 +13,7 @@ jobs: if: ${{ github.event.workflow_run.event == 'pull_request' }} steps: - name: 'Download change artifact' + id: download_change uses: dawidd6/action-download-artifact@v2 with: github_token: "${{ secrets.GITHUB_TOKEN }}" @@ -25,7 +26,7 @@ jobs: with: files: "change" - name: 'Comment on PR' - if: steps.check_change.outputs.files_exists == 'true' + if: steps.download_change.outputs.files_exists == 'true' && steps.check_change.outputs.files_exists == 'true' run: | export PR_NUMBER=$(cat change | jq -r '.pr') msg=$(cat change | jq -r '.body') From 24435c6476ddb9f0da894ede5469038e24b0af3c Mon Sep 17 00:00:00 2001 From: djchen Date: Sun, 4 Dec 2022 20:39:53 -0600 Subject: [PATCH 2/2] update breaking-change-detect --- .github/workflows/breaking-change-detect.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/breaking-change-detect.yaml b/.github/workflows/breaking-change-detect.yaml index dab4d6f..c18b71a 100644 --- a/.github/workflows/breaking-change-detect.yaml +++ b/.github/workflows/breaking-change-detect.yaml @@ -13,20 +13,20 @@ jobs: if: ${{ github.event.workflow_run.event == 'pull_request' }} steps: - name: 'Download change artifact' - id: download_change uses: dawidd6/action-download-artifact@v2 with: github_token: "${{ secrets.GITHUB_TOKEN }}" run_id: ${{ github.event.workflow_run.id }} workflow: pr-check.yaml name: change + if_no_artifact_found: ignore - name: Check change existence id: check_change uses: andstor/file-existence-action@v1 with: files: "change" - name: 'Comment on PR' - if: steps.download_change.outputs.files_exists == 'true' && steps.check_change.outputs.files_exists == 'true' + if: steps.check_change.outputs.files_exists == 'true' run: | export PR_NUMBER=$(cat change | jq -r '.pr') msg=$(cat change | jq -r '.body')