Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Same site compat check needs updating. #238

Closed
jmprieur opened this issue Jun 23, 2020 · 1 comment
Closed

[Bug] Same site compat check needs updating. #238

jmprieur opened this issue Jun 23, 2020 · 1 comment
Assignees
@pmaytak
Labels
bug Something isn't working fixed .NET Core 5 P1 reported-by-aspnetcore
Milestone
[1] .NET 5 Readin...

Comments

@jmprieur
Copy link
Collaborator

Which Version of Microsoft Identity Web are you using ?
Microsoft Identity Web 0.1.5-preview

Where is the issue?

  • Web App
    • [x ] Sign-in users

Other? - please describe;

Repro

Same site compat check needs updating.

Expected behavior
See https://www.chromium.org/updates/same-site/incompatible-clients

Actual behavior

microsoft-identity-web/src/Microsoft.Identity.Web/CookiePolicyOptionsExtensions.cs

Line 61 in 0b628e2

public static bool DisallowsSameSiteNone(string userAgent)

@pmaytak pmaytak self-assigned this Jun 25, 2020
@pmaytak pmaytak mentioned this issue Jun 27, 2020
Merged
@jennyf19
Copy link
Collaborator

Included in 0.2.0-preview release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmaytak pmaytak

Labels
bug Something isn't working fixed .NET Core 5 P1 reported-by-aspnetcore
Projects
None yet
Milestone
[1] .NET 5 Readiness - 0.2.0-preview
Development

No branches or pull requests
3 participants
@jmprieur @jennyf19 @pmaytak