Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] RegisterValidAudience.ValidateAudience should throw SecurityTokenInvalidAudienceException instead of SecurityTokenValidationException #242

Closed
8 tasks
brentschmaltz opened this issue Jun 23, 2020 · 2 comments
Assignees
Labels
bug Something isn't working fixed .NET Core 5 P1

Comments

@brentschmaltz
Copy link
Member

Which Version of Microsoft Identity Web are you using ?
Note that to get help, you need to run the latest version.

Where is the issue?
RegisterValidAudience.ValidateAudience
It would be consistent with other call graphs if SecurityTokenInvalidAudienceException was thrown.
InvalidAudience can also be set which can be added to logs for additional diagnostic support.

  • Web App
    • Sign-in users
    • Sign-in users and call web APIs
  • Web API
    • Protected web APIs (Validating tokens)
    • Protected web APIs (Validating scopes)
    • Protected web APIs call downstream web APIs
  • Token cache serialization
    • In Memory caches
    • Session caches
    • Distributed caches

Other? - please describe;

Is this a new or existing app?

Repro

var your = (code) => here;

Expected behavior
A clear and concise description of what you expected to happen (or code).

Actual behavior
A clear and concise description of what happens, e.g. exception is thrown, UI freezes

Possible Solution

Additional context/ Logs / Screenshots
Add any other context about the problem here, such as logs and screenshots.

@jmprieur jmprieur added .NET Core 5 bug Something isn't working P1 labels Jun 24, 2020
@jmprieur
Copy link
Collaborator

Thanks @brentschmaltz !

@jennyf19
Copy link
Collaborator

Included in 0.2.0-preview release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed .NET Core 5 P1
Projects
None yet
Development

No branches or pull requests

3 participants