Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] RegisterValidAudience.ValidateAudience does not throw if user set custom audiences. #243

Closed
brentschmaltz opened this issue Jun 23, 2020 · 2 comments
Closed

[Bug] RegisterValidAudience.ValidateAudience does not throw if user set custom audiences. #243

brentschmaltz opened this issue Jun 23, 2020 · 2 comments
Assignees
@pmaytak
Labels
bug Something isn't working fixed .NET Core 5 P1
Milestone
[1] .NET 5 Readin...

Comments

@brentschmaltz
Copy link
Member

brentschmaltz commented Jun 23, 2020 •
edited by jmprieur
Loading

Which Version of Microsoft Identity Web are you using ?
Microsoft Identity Web 0.1.5-preview

Where is the issue?
The normal call graph through asp.net results in a call to Validators.Validate where an exception is thrown if a validate audience is not found, even if the user has added custom audiences.
@jmprieur jmprieur added bug Something isn't working P1 .NET Core 5 labels Jun 24, 2020
@pmaytak pmaytak self-assigned this Jun 30, 2020
@pmaytak pmaytak mentioned this issue Jul 2, 2020
Merged
@pmaytak pmaytak added fixed and removed In progress labels Jul 2, 2020
@jmprieur
Copy link
Collaborator

jmprieur commented Jul 2, 2020

Also fixed by #275

@jennyf19
Copy link
Collaborator

Included in 0.2.0-preview release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmaytak pmaytak

Labels
bug Something isn't working fixed .NET Core 5 P1
Projects
None yet
Milestone
[1] .NET 5 Readiness - 0.2.0-preview
Development

No branches or pull requests
4 participants
@brentschmaltz @jmprieur @jennyf19 @pmaytak