Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pedestal Button that can be placed in Right-Middle-Left Positions plus rotation toggle #1758

Closed
LautaroL20 opened this issue Mar 17, 2017 · 24 comments
Assignees
Labels
New Feature A new item, option, or other feature

Comments

@LautaroL20
Copy link
Member

20170317152636_1

@LautaroL20 LautaroL20 added the New Feature A new item, option, or other feature label Mar 17, 2017
@LautaroL20 LautaroL20 self-assigned this Mar 17, 2017
@Konclan
Copy link
Collaborator

Konclan commented Mar 17, 2017

This technically already exists

@vrad-exe
Copy link
Member

Basically, the Protruding Pedestal Button minus the protruding.

@vrad-exe
Copy link
Member

vrad-exe commented Mar 17, 2017

This could just be added to the original item.

Just realized this isn't a good idea, see here.

@LautaroL20
Copy link
Member Author

@Konclan - No, you still woudn´t be able to use my protruding ped buttons with a "Track Plataform" close to it because it will gonna say invalid position because floating, this is why this item would be useful:
20170317160947_1

@vrad-exe
Copy link
Member

Make sure the middle button has a 2-tile wide base, the original 3-tile base looks kind of weird since it's not aligned to the tile grid...

@vrad-exe
Copy link
Member

Maybe call this the "Pedestal Button Plus"

@TheDarkBomber
Copy link
Contributor

Duplicate of #447.

@FrozenDragon0 FrozenDragon0 added the Duplicate This issue has already been reported label Mar 18, 2017
@LautaroL20
Copy link
Member Author

No it isn´t.

@LautaroL20 LautaroL20 reopened this Mar 18, 2017
@LautaroL20 LautaroL20 removed the Duplicate This issue has already been reported label Mar 18, 2017
@TheDarkBomber
Copy link
Contributor

It is.

@LautaroL20
Copy link
Member Author

LautaroL20 commented Mar 18, 2017

@TheDarkBomber - No, its not. Can you see the label or do you need a pair of glasses? It says "New Item".

@TheDarkBomber
Copy link
Contributor

So is #447.

@LautaroL20
Copy link
Member Author

That one is just about giving a simple rotation toggle for Valve´s pedestal. This one is about a new button variant.

@TheDarkBomber
Copy link
Contributor

Instead of opening a new issue, why not just edit that one?

@LautaroL20
Copy link
Member Author

Because merging this in the PeTi´s pedestal would break the ITEM_BUTTON_PEDESTAL condition, and that implies breaking old puzzles files as well as the item´s collisions into the Editor.

@TheDarkBomber
Copy link
Contributor

🤦‍♂️ I said edit the issue. Not the item.

@LautaroL20
Copy link
Member Author

LautaroL20 commented Mar 18, 2017

Because this must be a separated issue since it has nothing to do with the konclan´s one anymore.... Issue #447 will also gonna be implemented. I think it isn´t too hard to understand, isn´t it?

@ghost
Copy link

ghost commented Mar 18, 2017

Duplicate of #477

It isn't.

@vrad-exe
Copy link
Member

That's why you don't give @TheDarkBomber admin access to anything, if he were a collaborator right now he'd probably be locking this or something...

@LautaroL20
Copy link
Member Author

LautaroL20 commented Mar 18, 2017

Indeed, this would have turned into a constant close-re-open annoyance situation where all of you would had a massive list of notifications into your e-mail inboxes, until someone flagged @TheDarkBomber to the Github Support.

@vrad-exe
Copy link
Member

No, its not. Can you see the label or do you need a pair of glasses? It says "New Item".

So is #447.

I think he does need glasses, #447 does NOT have the New Item label and never did.

@ghost
Copy link

ghost commented Mar 19, 2017

I think he does need glasses, #447 does NOT have the New Item label and never did.

Lol, he does.

@ghost
Copy link

ghost commented May 3, 2017

So, any info about this?

@LautaroL20
Copy link
Member Author

Glad to see you interesting, once i make the BTS Model Editor for the pedestal button, i will do it.

@LautaroL20
Copy link
Member Author

This is now implemented. You can test it by using the Dev version, or just wait for the PRL26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature A new item, option, or other feature
Projects
None yet
Development

No branches or pull requests

5 participants