Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error on latetst ACF 5 pro and 4.3.1 #16

Open
jmslbam opened this issue Jan 13, 2016 · 1 comment
Open

Fatal error on latetst ACF 5 pro and 4.3.1 #16

jmslbam opened this issue Jan 13, 2016 · 1 comment

Comments

@jmslbam
Copy link

jmslbam commented Jan 13, 2016

Wanted to use this plugin but got this error, sorry can't send a PR, but I did wanted it to let you know:

Notice: Uninitialized string offset: 0 in /srv/http/els_wp_local/current/public/app/plugins/advanced-custom-fields-link-picker-field/acf-link_picker-v5.php on line 147

The field is inside a flexible content field > and then within a repeater field :)

@jmslbam
Copy link
Author

jmslbam commented Jan 13, 2016

Ok found it

if ( empty( $field['value'] ) || $field['value'] === FALSE || (isset($field['value']['url']) && $field['value']['url'] == '') )
        {
            $field['value']['url'] = '';
            $field['value']['title'] = '';
            $field['value']['target'] = '';
            $exists = false;
        }

On line # 147 it calls the $field['value'] but well.. that one is empty.
So now the field does display, but after click the "insert link" button. it submits the page.

New bug..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant